[m-rev.] Documentation and test case for abstract typeclasses.

[Ralph Becket]

Fergus Henderson, Thursday, 31 October 2002:
> 
> Sorry, I did a bad job of reviewing this one.
> 
> First, those two changes both require each other, and both constitute part
> of a single logical change -- they should have been listed as a single
> change, not two separate changes.  It's OK to put the documentation
> change separately, but please do not include more than one change in a
> single email.

Righto.

> Second, the test case should go in tests/hard_coded/typeclasses,
> not in a new directory tests/typeclasses.

The directory tests/typeclasses was already there, but unpopulated.
It being the first one I found with the right name, I assumed that
was where the tests should go.

> In fact, now that I look there, I see there is already a test case for
> the use of abstract typeclasses.  Mark Brown added it about a week or
> two ago.  It looks like this test already tests everything that your test
> case tests, and a bit more, so I suggest we just delete your test case.
> 
> Also, the nightly tests failed due to tests/typeclasses/Mercury.options
> not existing.  This problem will go away if we make the change
> suggested above.

Okay.  I've got to run now; I'll do that tomorrow.

- Ralph
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------