[m-rev.] Documentation and test case for abstract typeclasses.

[Fergus Henderson]

On 30-Oct-2002, Ralph Becket <rafe at cs.mu.OZ.AU> wrote:
> 
> Estimated hours taken: 0.1
> Branches: main
> 
> tests/Mmakefile:
> 	Added typeclasses subdirectory to list of test directories.
...
> Estimated hours taken: 0.5
> Branches: main
> 
> tests/typeclasses/Mmakefile:
> 	Added.
> 
> tests/typeclasses/abstract_typeclasses.m:
> tests/typeclasses/abstract_typeclasses.exp:
> 	New test case.

Sorry, I did a bad job of reviewing this one.

First, those two changes both require each other, and both constitute part
of a single logical change -- they should have been listed as a single
change, not two separate changes.  It's OK to put the documentation
change separately, but please do not include more than one change in a
single email.

Second, the test case should go in tests/hard_coded/typeclasses,
not in a new directory tests/typeclasses.

In fact, now that I look there, I see there is already a test case for
the use of abstract typeclasses.  Mark Brown added it about a week or
two ago.  It looks like this test already tests everything that your test
case tests, and a bit more, so I suggest we just delete your test case.

Also, the nightly tests failed due to tests/typeclasses/Mercury.options
not existing.  This problem will go away if we make the change
suggested above.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------