[m-rev.] for review: hlc.par.gc with MSVC

[Fergus Henderson]

On 25-Oct-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> Estimated hours taken: 5
> Branches: main
> 
> Get the hlc.par.gc grade compiling with MSVC 7.0.

That looks fine, except for one part:

> runtime/mercury_builtin_types.c:
> 	Add valid returns to the functions which call MR_fatal_error
> 	so as to stop the C compiler from complaining.

These unreachable return statements are not needed, make the code less
readable, and may cause warnings with future versions of gcc, because
they are unreachable.  A better fix would be to change MSVC to support
__attribute__((noreturn)) or the equivalent.  If MSVC doesn't support
anything like that, please send feedback to MS.

If the warnings are annoying, add appropriate compilation options
(or perhaps #pragmas) to disable them.

> boehm_gc/gc.mak:
> 	Update the make file to build libpar_gc.dll instead of gc.dll.

This change would be much simpler (and less likely to result in CVS
merge conflicts) if you left it to be created as Release/gc.dll
and then copied it to libpar_gc.dll, rather than trying to create
it as Release/libpar_gc.dll.

> +The following flag needs to be passed to the compiler, when compiling
> +in the none.* grades to avoid a limitation in the C compiler.

Please fix the commas in that sentence.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------