[m-rev.] for review: disable equiv_type special pred and type_ctor_info generation for il backend

Peter Ross pro at missioncriticalit.com
Sun Nov 10 08:01:57 AEDT 2002


fjh wrote:

> On 09-Nov-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> > +  % Equivalence types are fully expanded on the IL and Java
> > +  % backends, so the special predicates aren't required.
> > + { ( Target = il ; Target = java),
>
> This test occurs twice in your diff.  It should be abstracted out into
> a single predicate rather than being duplicated.
>
Which module should this test go in?  I was thinking code_util, do you
agree?

> The test is not quite right; for the IL back-end, equivalence types
> are only expanded if --high-level-data is set.  I don't think we're
> quite ready to deliberately break the "ilc" grade yet, are we?
>
Ah yes, thanks for pointing this out.

> Also, currently for Java we do not yet fully expand all equivalence types
> (i.e. intermodule optimization is not automatically enabled).
> IMHO this is a bug, though.  But it's probably worth mentioning
> this in the comments.
>
I will submit a seperate diff which enables intermodule-optimization for the
java backend.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list