[m-rev.] for review: disable equiv_type special pred and type_ctor_info generation for il backend

Fergus Henderson fjh at cs.mu.OZ.AU
Sun Nov 10 03:18:05 AEDT 2002


On 09-Nov-2002, Peter Ross <pro at missioncriticalit.com> wrote:
> +  % Equivalence types are fully expanded on the IL and Java
> +  % backends, so the special predicates aren't required.
> + { ( Target = il ; Target = java),

This test occurs twice in your diff.  It should be abstracted out into
a single predicate rather than being duplicated.

The test is not quite right; for the IL back-end, equivalence types
are only expanded if --high-level-data is set.  I don't think we're
quite ready to deliberately break the "ilc" grade yet, are we?

Also, currently for Java we do not yet fully expand all equivalence types
(i.e. intermodule optimization is not automatically enabled).
IMHO this is a bug, though.  But it's probably worth mentioning
this in the comments.

Apart from that, this looks fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list