[m-rev.] Fixes to pprint and change for --dump-mlds

[Ralph Becket]

Mark Brown, Wednesday, 24 October 2001:
> On 24-Oct-2001, Ralph Becket <rafe at cs.mu.OZ.AU> wrote:
> 
> I think we're talking about the same thing.  I want to see test cases
> that would have failed before committing this change, but which now
> produce correct output.

Righto.

> > I'd like to put that off until I've finished another change I'm working
> > on to do with formatting infix operators.
> 
> Please save that for a separate change (which I'll also be happy to
> review).

Yes, I'm working on that as a separate change.

> I didn't explicitly ask for it, but our convention is to post relative
> diffs on the second and subsequent rounds of reviewing (you can produce
> these from two existing diffs using 'interdiff').

Will do.

> Minor changes like this are good candidates to be committed separately
> as a "trivial diff".  But we often bend the rules and piggy-back such
> changes along with a larger review, so I'm happy for you to leave it in
> here.

Okay, I'll try to avoid mixing the two in futuer.

> I am happy with the part of the change which fixes the performance bug.
> The rest of the change I'll review when test cases are available.

Coming up...

- Ralph
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------