[m-rev.] for review: bug fix for library/time.m
Simon Taylor
stayl at cs.mu.OZ.AU
Thu May 31 17:52:12 AEST 2001
On 31-May-2001, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 31-May-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> >
> > library/time.m:
> > Fix a bug: type `tm' didn't contain a member to store the
> > day of the month, so functions which used that member, for
> > example time__mktime, would not work.
>
> mktime() ignores the tm_wday and tm_yday fields.
> So that's not a good example.
It was the tm_mday field which was missing.
The code in tests/hard_coded/time_test.m which tests time__mktime did fail.
> > +++ NEWS 2001/05/31 06:11:46
> > @@ -30,6 +30,10 @@
> > * The exception module has a new predicate `try_store', which is
> > like `try_io', but which works with stores rather than io__states.
> >
> > +* We've fixed a bug in time.m. Type `tm' didn't store the day of the month,
> > + which meant that predicates which required that field (e.g. time__asctime,
> > + time__mktime) did not work.
>
> s/predicates/functions/
Done.
> Also modify the message so that it refers only to time__asctime,
> not to time__mktime.
Not done.
Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list