[m-rev.] for review: bug fix for library/time.m

Fergus Henderson fjh at cs.mu.OZ.AU
Thu May 31 17:43:37 AEST 2001


On 31-May-2001, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> 
> library/time.m:
> 	Fix a bug: type `tm' didn't contain a member to store the
> 	day of the month, so functions which used that member, for
> 	example time__mktime, would not work.

mktime() ignores the tm_wday and tm_yday fields.
So that's not a good example.

I think time__asctime is the only procedure affected by the problem.

> +++ NEWS	2001/05/31 06:11:46
> @@ -30,6 +30,10 @@
>  * The exception module has a new predicate `try_store', which is
>    like `try_io', but which works with stores rather than io__states.
>  
> +* We've fixed a bug in time.m. Type `tm' didn't store the day of the month,
> +  which meant that predicates which required that field (e.g. time__asctime,
> +  time__mktime) did not work.

s/predicates/functions/

Also modify the message so that it refers only to time__asctime,
not to time__mktime.

Otherwise that change looks good.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
                                    |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list