[m-rev.] for review: deep profiling.

[Thomas Conway]

On Thu, May 03, 2001 at 06:18:38PM EST, Zoltan Somogyi wrote:
> For review by Tom and by someone else.
> 

You don't seem to have included a diff for the deep directory.

> Index: library/profiling_builtin.m
	[deletia]
> +%---------------------------------------------------------------------------%
> +% Call port procedures
> +%---------------------------------------------------------------------------%
> +
> +:- pragma c_code(det_call_port_code_ac(ProcStatic::in, TopCSD::out,
> +		MiddleCSD::out),
> +		[thread_safe, will_not_call_mercury],
> +"{
> +/* shut up warning: ProcStatic, TopCSD, MiddleCSD */
> +#define procname	""det_call_port_code_ac""
> +#define version_ac
> +#undef need_new_outermost
> +#include ""mercury_deep_call_port_body.h""
> +#undef procname
> +#undef version_ac
> +}").
> +

Shouldn't these macro names have MR_ prefixes or some other
appropriate namespacing (also for the rest of profiling_builtin.m)?

-- 
  Thomas Conway )O+
 <conway at cs.mu.oz.au>       499 User error! Replace user, and press any key.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------