[m-dev.] promoted ROTDs

[Zoltan Somogyi]

On Tue, 24 Jul 2018 11:56:02 +1000, Peter Wang <novalazy at gmail.com> wrote:

> On Tue, 24 Jul 2018 11:19:58 +1000, Peter Wang <novalazy at gmail.com> wrote:
> > 
> > Is there anything known to be wrong with rotd-2018-07-23?
> 
> There are some C compiler warnings in hlc grades that would be better to
> fix first, e.g.
> 
> bitmap.c: In function 'mercury__bitmap__to_string_chars_4_p_0':
> bitmap.c:2627:26: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
>          MR_Word Var_25 = ((MR_Box) ((MR_String) "bitmap.to_string: internal error"));
> 
> lexer.c: In function 'mercury__lexer__string_get_source_line_number_7_p_0':
> lexer.c:9887:27: warning: assignment makes integer from pointer without a cast [-Wint-conversion]
>              *HaveToken_12 = ((MR_Box) ((MR_Integer) -1));

Does anyone have any experience with using -Werror, gcc's equivalent of
--halt-at-warn? I am thinking it would be a good idea to turn it on in bootchecks
after this bug is fixed, to detect such problems at the source. And is there an
equivalent for clang?

Zoltan.