[m-dev.] for review: build hlc.par.gc using MSVC
Fergus Henderson
fjh at cs.mu.OZ.AU
Mon Sep 11 21:26:24 AEDT 2000
On 06-Sep-2000, Peter Ross <peter.ross at miscrit.be> wrote:
> > +++ scripts/mgnuc.in 2000/08/31 14:32:13
> > @@ -57,6 +57,12 @@
> > OPT_OPTS=""
> > COMPILER=lcc
> > ;;
> > + *cl* | *CL*)
> > + ANSI_OPTS=""
> > + CHECK_OPTS=""
> > + OPT_OPTS=""
> > + COMPILER=cl
> > + ;;
It would help to have a comment here saying what "cl" is.
Hmm, there is a non-trivial danger of false hits with the pattern
"*cl*". Not sure if we should worry about that.
> > + *cygwin32*)
> > + case $COMPILER in
> > + cl) THREAD_OPTS="-DMR_THREAD_SAFE /MD"
> > + ;;
I suggest s/cygwin32/cygwin/,
since the "32" is no longer part of the name.
> > +++ scripts/ml.in 2000/08/31 14:32:13
> > @@ -41,6 +41,21 @@
> > LINK=/stack:10485760 # 10 Mb
> > export LINK
> >
> > +case "$CC" in
> > + *gcc*)
> > + COMPILER=gcc
> > + ;;
> > + *lcc*)
> > + COMPILER=lcc
> > + ;;
> > + *cl* | *CL*)
> > + COMPILER=cl
> > + ;;
> > + *)
> > + COMPILER=unknown
> > + ;;
> > +esac
Likewise here a comment explaining what `cl' is would be helpful.
You could also add comments for gcc and lcc, e.g.
# GNU C (see gcc.gnu.org)
# Fraser and Hanson's lcc
# (see http://www.cs.princeton.edu/software/lcc/)
but I think it is more widely known what `gcc' and (to a lesser extent)
lcc are than what `cl' is.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh> | of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3 | -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to: mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions: mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------
More information about the developers
mailing list