[m-dev.] for review: parse "term `Var` term"

[Peter Ross]

On 12-Feb-2000, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 11-Feb-2000, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> > For Fergus to review.
> 
> This change looks good.  I have just one minor suggestion
> (see below).
> 
> > I am assuming that this should be backported to the 0.9.x branch as
> > well.
> 
> Yes, that would be great.
> 
Have done, however it causes the test interpreter.m to fail in the
debugger dir.

I believe that it is a spurious error, because it looks like the code
tests the goto and step commands.

Is this correct?

If it is correct, what do I need to do to generate the different .exp
files.  I assume that they depend what grades the tests were compiled
in.

> ...
> > @@ -390,7 +402,8 @@
> >  		( { RightTerm0 = ok(RightTerm) } ->
> >  			parser__get_term_context(Context, TermContext),
> >  			{ OpTerm = term__functor(term__atom(Op),
> > -				[LeftTerm, RightTerm], TermContext) },
> > +				append(VariableTerm, [LeftTerm, RightTerm]),
> > +				TermContext) },
> 
> I suggest you use the module-qualified name `list__append' here,
> rather than using unqualified `append'.
> 
OK.

Pete
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------