[m-dev.] for review: parse "term `Var` term"

Fergus Henderson fjh at cs.mu.OZ.AU
Sat Feb 12 18:06:30 AEDT 2000


On 11-Feb-2000, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> For Fergus to review.

This change looks good.  I have just one minor suggestion
(see below).

> I am assuming that this should be backported to the 0.9.x branch as
> well.

Yes, that would be great.

...
> @@ -390,7 +402,8 @@
>  		( { RightTerm0 = ok(RightTerm) } ->
>  			parser__get_term_context(Context, TermContext),
>  			{ OpTerm = term__functor(term__atom(Op),
> -				[LeftTerm, RightTerm], TermContext) },
> +				append(VariableTerm, [LeftTerm, RightTerm]),
> +				TermContext) },

I suggest you use the module-qualified name `list__append' here,
rather than using unqualified `append'.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------



More information about the developers mailing list