[m-dev.] "diff" vs "for review"

[Tyson Dowd]

On 25-Mar-1999, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 25-Mar-1999, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> > If anyone wants to review this feel free.  I have already committed the
> > changes.
> 
> Normally we use "diff:" rather than "for review:" if the change has
> already been committed.  I think the intended meanings of the
> various prefixes is roughly as follows:
> 
> 	prefix		meaning
> 	------		-------
> 	for review:	Please review this.  Not yet committed.
> 			There's a good chance that this change
> 			will be modified in response to reviewers'
> 			comments.
> 
> 	diff:		Already committed, but a review is probably
> 			a good idea anyway.
> 
> 	trivial diff:	Already committed, and the change is trivial,
> 			so no review should be needed.
> 			Read this message only if you are paranoid.

compiler/notes/reviews.html sets out the exact conditions for what
sort of changes correspond with each category.

Your summary is a good interpretation of what each prefix means
(although it doesn't say when you should be using them).

-- 
The quantum sort: 
	while (!sorted) { do_nothing(); }
Tyson Dowd   <tyson at tyse.net>   http://tyse.net/