"diff" vs "for review"

[Fergus Henderson]

On 25-Mar-1999, Peter Ross <petdr at cs.mu.OZ.AU> wrote:
> If anyone wants to review this feel free.  I have already committed the
> changes.

Normally we use "diff:" rather than "for review:" if the change has
already been committed.  I think the intended meanings of the
various prefixes is roughly as follows:

	prefix		meaning
	------		-------
	for review:	Please review this.  Not yet committed.
			There's a good chance that this change
			will be modified in response to reviewers'
			comments.

	diff:		Already committed, but a review is probably
			a good idea anyway.

	trivial diff:	Already committed, and the change is trivial,
			so no review should be needed.
			Read this message only if you are paranoid.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.