[m-dev.] for review: Aditi updates[2]

[Simon Taylor]

> > Index: compiler/hlds_pred.m
> > +	% We internally store the arity as the length of the argument
> > +	% list, which is one more than the arity of a function reported
> > +	% in error messages.
> > +:- pred adjust_func_arity(pred_or_func, int, int).
> > +:- mode adjust_func_arity(in, in, out) is det.
> > +:- mode adjust_func_arity(in, out, in) is det.
> 
> I think the comment here ought to mention the words "return value"
> somewhere, to explain why the arity of functions needs to be adjusted.

        % We internally store the arity as the length of the argument
        % list including the return value, which is one more than the
        % arity of the function reported in error messages.

> > Index: compiler/lambda.m
> The meaning of the `no's here is unclear.
...
> > Index: compiler/magic_util.m
> Likewise here.

...
> Likewise here.

Fixed.

Simon.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------