[m-dev.] for review: Aditi updates[3]

[Simon Taylor]

> make_hlds.m:

> > +		{ FoundError = yes },
> > +		% Don't report spurious type errors for clauses
> > +		% containing other errors.
> > +		{ ClausesInfo = ClausesInfo0 }
> 
> I think it would be better if the comment here explained things
> in a bit more detail.  

OK.
 
> ...
> > +:- pred transform_aditi_builtin(string, list(prog_term), prog_context,
> > +		prog_varset, hlds_goal, prog_varset,
> > +		qual_info, qual_info, io__state, io__state).
> > +:- mode transform_aditi_builtin(in(aditi_update_str), in,
> > +		in, in, out, out, in, out, di, uo) is det.
> 
> Please add some comments to the definition of this predicate.

Done.

> > +:- pred transform_delete_or_modify(string, list(prog_term), prog_context,
> > +		prog_varset, hlds_goal, prog_varset,
> > +		qual_info, qual_info, io__state, io__state).
> > +:- mode transform_delete_or_modify(in(aditi_del_or_mod_str), in,
> > +		in, in, out, out, in, out, di, uo) is det.
> 
> Likewise for this one (there were a couple of comments, but there was
> still plenty of code that was unexplained and not immediately obvious).

Done.

> > +transform_delete_or_modify(DelOrMod, Args0, Context, VarSet0,
> > +		UpdateGoal, VarSet, Info0, Info) -->
> ...
> > +			% First syntax -
> > +			% aditi_modify((p(X0, Y0, _DB0) = p(X0, Y, _DB) :-
> > +			%	X0 < 100, Y = Y0 + 1), DB0, DB).
> 
> I don't much like the use of `=' here.  I think `==>' or something like
> that would be better.

Done.

Simon.
--------------------------------------------------------------------------
mercury-developers mailing list
Post messages to:       mercury-developers at cs.mu.oz.au
Administrative Queries: owner-mercury-developers at cs.mu.oz.au
Subscriptions:          mercury-developers-request at cs.mu.oz.au
--------------------------------------------------------------------------