for review: --stack-trace-higher-order

Zoltan Somogyi zs at cs.mu.OZ.AU
Tue Nov 3 15:31:07 AEDT 1998


> > -output_c_module_init_list(ModuleName, Modules) -->
> > +output_c_module_init_list(ModuleName, Modules, StackLayoutLabels) -->
> > -		% Output initialization functions, bunched into groups
> > -		% of 40.
> > +	{ divide_modules_on_init_status(Modules, StackLayoutLabels,
> > +		AlwaysInitModules, MaybeInitModules) },
> > +	{ list__chunk(AlwaysInitModules, 40, AlwaysInitModuleBunches) },
> > +	{ list__chunk(MaybeInitModules, 40, MaybeInitModuleBunches) },
> > +	globals__io_lookup_bool_option(split_c_files, SplitFiles),
> 
> > +	output_init_bunch_defs(AlwaysInitModuleBunches, ModuleName,
> > +		"always", 0, SplitFiles),
> 
> The comment there was deleted, but I think it should stay.
> If it's not completely appropriate after your changes, then please
> replace it with a comment that is appropriate, rather than just
> deleting it.

There is not point in comments of the form "a += 1; /* add one to a */".
Given the calls to list__chunk, the old comment would now be of this form.

The "why" comment is already there, at the start of the predicate
divide_modules_on_init_status.

Zoltan.



More information about the developers mailing list