for review: --stack-trace-higher-order

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Nov 2 20:08:06 AEDT 1998


On 01-Nov-1998, Zoltan Somogyi <zs at cs.mu.OZ.AU> wrote:
> 
> compiler/llds_out.m:
> -output_c_module_init_list(ModuleName, Modules) -->
> +output_c_module_init_list(ModuleName, Modules, StackLayoutLabels) -->
> -		% Output initialization functions, bunched into groups
> -		% of 40.
> +	{ divide_modules_on_init_status(Modules, StackLayoutLabels,
> +		AlwaysInitModules, MaybeInitModules) },
> +	{ list__chunk(AlwaysInitModules, 40, AlwaysInitModuleBunches) },
> +	{ list__chunk(MaybeInitModules, 40, MaybeInitModuleBunches) },
> +	globals__io_lookup_bool_option(split_c_files, SplitFiles),

> +	output_init_bunch_defs(AlwaysInitModuleBunches, ModuleName,
> +		"always", 0, SplitFiles),

The comment there was deleted, but I think it should stay.
If it's not completely appropriate after your changes, then please
replace it with a comment that is appropriate, rather than just
deleting it.

> -		% Output code to call each of the init functions created
> -		% above.
>  	io__write_string("void "),
>  	output_init_name(ModuleName),
>  	io__write_string("(void);"),

Likewise.

Otherwise, the changes to llds_out.m look fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list