[m-dev.] Help committing

[Fergus Henderson]

On 18-Jun-1998, Warwick Harvey <wharvey at cs.monash.edu.au> wrote:
> Fergus writes:
> > Please test it.
> 
> I don't think it worked as intended.  :-)  First I tried without the extra 
> option, partly just to make sure I was still up-to-date.  I was a little 
> surprised when it continued with the commit, with none of the expected 
> warning or error messages (i.e. it didn't even say it was fixing the groups, 
> though all the repository files do seem to have the correct group).  What I 
> did get was:
> 
> cvs server: commitinfo:21: no such user variable ${=commit_opts}
> cvs server: commitinfo:21: no such user variable ${=commit_opts}
> cvs server: commitinfo:21: no such user variable ${=commit_opts}
> cvs server: commitinfo:21: no such user variable ${=commit_opts}
> 
> ... and then RCS's messages as it started checking things in.

Oh well.  I was hoping that cvs would just substitute an empty string
if the variable was not set.  But that's not the case.  It looks
like cvs doesn't provide any easy way of doing it. I'll undo my change.

I just sent of a patch to the cvs maintainers that allows `${?commit_opts}'
with the semantics we want.  If they accept that patch, then we can
re-enable this (after installing new versions of cvs everywhere :-( )..

--------------------

CVSROOT/commitinfo:
CVSROOT/check.pl:
	Undo my previous change to allow overriding of the commit checks
	over remote cvs, since it didn't work -- it seems that cvs doesn't
	provide any easy way of achieving this.

cvs diff  CVSROOT/check.pl CVSROOT/commitinfo
Index: CVSROOT/check.pl
===================================================================
RCS file: /home/mercury1/repository/CVSROOT/check.pl,v
retrieving revision 1.7
diff -u -r1.7 check.pl
--- check.pl	1998/06/18 04:17:45	1.7
+++ check.pl	1998/06/18 05:39:25
@@ -124,8 +124,7 @@
 			} else {
 				print "\nCan't read from your terminal.\n";
 				print "You appear to be using remote cvs.\n";
-				print "Use `cvs -s commit_opts=--force " .
-					"commit ...' to override.\n";
+				print "I guess you're screwed, then.\n";
 				$retval = 1;
 			}
 		}
Index: CVSROOT/commitinfo
===================================================================
RCS file: /home/mercury1/repository/CVSROOT/commitinfo,v
retrieving revision 1.5
diff -u -r1.5 commitinfo
--- commitinfo	1998/06/18 04:17:46	1.5
+++ commitinfo	1998/06/18 05:45:13
@@ -18,5 +18,5 @@
 # in addition to the first matching regex or DEFAULT.
 #
 #^cvs		checkforcvsid
-DEFAULT		/home/mercury1/repository/CVSROOT/check.pl ${=commit_opts}
+DEFAULT		/home/mercury1/repository/CVSROOT/check.pl
 		# check group id and group read permission
-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.