[m-dev.] another pb in mercury_trace.c

[Fergus Henderson]

On 16-Jul-1998, Erwan Jahier <Erwan.Jahier at irisa.fr> wrote:
> A call to fatal_abort() is made in
> mercury_trace.c:MR_trace_event_report(). fatal_abort() is defined in
> mercury_memory_handler.c (under a #ifndef MERCURY_MEMORY_HANDLERS_H) but
> its prototype is not declared in mercury_memory_handler.h, so it induce
> an error ("undefined symbol ...").
> 
> What should be the fix:
> 1) declare MR_trace_event_report() prototype in mercury_memory_handler.h
> (even if it is under a #ifndef).
> 
> 2) replace fatal_abort() by fatal_error() ?

I think 2) is the correct fix.

fatal_abort() is only needed for code that could be called from a signal
handler, which I don't think is the case here.

> ps: I have noticed several other problems; I started to deal with them
> one by one. I you prefer I deal with all of them in one time, just tell
> me.

One by one is fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.