[m-dev.] diff/for review: changes to runtime for non-gcc C compilers

[Tyson Dowd]

On 15-Jul-1998, Fergus Henderson <fjh at cs.mu.OZ.AU> wrote:
> On 15-Jul-1998, Tyson Dowd <trd at stimpy.cs.mu.oz.au> wrote:
> > > -Word *
> > > +static Word *
> > >  deep_copy_type_info(Word *type_info, Word *lower_limit, Word *upper_limit)
> > >  {
> > >  	if (in_range(type_info)) {
> > 
> > XXX check this in my change.
> 
> ?

oops, that's a note for me, not for you.  Ignore it.

> 
> > > -  MR_MAKE_STACK_LAYOUT_ENTRY(engine_done);
> > > +  MR_MAKE_STACK_LAYOUT_ENTRY(engine_done)
> > 
> > Wouldn't it be easier to leave the semicolon off the macro definition
> > than all the uses? Otherwise people are just going to add new ones
> > with semicolons anyway.
> 
> The trouble with that is that the macro expands to nothing if
> stack layouts are not enabled.
> 
> I could change it to expand to something like
> `extern int MR_unused_bogus_variable' instead of nothing.
> But that seemed like a bit of a hack to me.

True.  So long as you're happy with the fact this is likely to happen
again.

-- 
       Tyson Dowd           # "Bill Gates is a white persian cat and a monocle
                            # away from becoming another James Bond villan."
     trd at cs.mu.oz.au        # "No Mr Bond, I expect you to upgrade."
http://www.cs.mu.oz.au/~trd #                -- Dennis Miller and Terri Branch