[m-dev.] for review: enhancements to mtags script

Fergus Henderson fjh at cs.mu.OZ.AU
Mon Jul 6 17:30:26 AEST 1998


On 06-Jul-1998, David Matthew Overton <dmo at cs.mu.OZ.AU> wrote:
> On Mon, Jul 06, 1998 at 04:55:39PM +1000, Andrew Bromage wrote:
> > 
> > Quite a few times, there appears this construction:
> > 
> > > +		    $_ = <srcfile>;
> > > +		    chop;
> > > +		    $body = $_;
> > 
> > Wouldn't it be simpler (and cleaner) to use this?
> > 
> > 	$body = <srcfile>;
> > 	chop $body;
> > 
> Probably.  I just copied the style that was already in the script,
> assuming that the person who originally wrote it must have known what
> they were doing better than a Perl newbie like me.

Andrew Bromage is right here.  Could you please change all occurrences
of this as he suggested?

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.



More information about the developers mailing list