for review: add mercury_opengl library

[Fergus Henderson]

On 16-Feb-1998, Tyson Dowd <trd at cs.mu.OZ.AU> wrote:
> extras/graphics/mercury_opengl/*

Would it be better to use the directory name `opengl'?

> extras/graphics/mercury_opengl/HOWTO:
> extras/graphics/mercury_opengl/mercury_opengl.m:
> extras/graphics/mercury_opengl/mglu.m:
> extras/graphics/mercury_opengl/mogl.m:
> extras/graphics/mercury_opengl/mtogl.m:
> extras/graphics/mercury_opengl/tkConsole.c:
> extras/graphics/mercury_opengl/tkFont.h:
> extras/graphics/mercury_opengl/tkInt4.0.h:
> extras/graphics/mercury_opengl/tkInt4.1.h:
> extras/graphics/mercury_opengl/tkInt4.2.h:
> extras/graphics/mercury_opengl/tkInt8.0.h:
> extras/graphics/mercury_opengl/tkInt8.0p2.h:
> extras/graphics/mercury_opengl/tkPort.h:
> extras/graphics/mercury_opengl/tkWin.h:
> extras/graphics/mercury_opengl/tkWinInt.h:
> extras/graphics/mercury_opengl/tkWinPort.h:
> extras/graphics/mercury_opengl/togl.c:
> extras/graphics/mercury_opengl/togl.h:
> 	Same old .m files (except mercury_opengl.m), new Mmakefile,
> 	new LICENSEs, updated version of Togl.

Are you moving the .m files from extras/graphics to
extras/graphics/mercury_opengl, or are you adding new copies?
The log message isn't clear.

> New File: extras/graphics/mercury_opengl/HOWTO
> ===================================================================
...
> 	# Tell mmake to use the `mercury_tcltk' library.
> 	VPATH           = $(MERCURY_TCLTK_DIR):$(MMAKE_VPATH)
> 	MCFLAGS         = -I$(MERCURY_TCLTK_DIR) $(EXTRA_MCFLAGS)
> 	MLFLAGS         = -R$(MERCURY_TCLTK_DIR) $(EXTRA_MLFLAGS) \
> 			  -L$(MERCURY_TCLTK_DIR) 
> 	MLLIBS          = -lmercury_tk $(EXTRA_MLLIBS)

Should that be `-lmercury_tcltk'?

> New File: extras/graphics/mercury_opengl/Mmakefile
> ===================================================================
> 
> MAIN_TARGET = all
> 
> MLOBJS		= togl.pic_o 

I think that should be `togl.o', not `togl.pic_o'.
ml will link with togl.pic_o anyway.
See "Using Libraries" in the user guide.

> all: togl.pic_o libmercury_opengl 

Should be just
	all: libmercury_opengl 

perhaps with

	libmercury_opengl : togl.$(something)

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.