[m-dev.] diff: fixes for demangling
Fergus Henderson
fjh at cs.mu.oz.au
Thu Jul 24 17:01:08 AEST 1997
Tyson Richard DOWD, you wrote:
>
> > + ( remove_prefix("__Unify__") ->
> > + { Category = unify }
> > + ; remove_prefix("__Compare__") ->
> > + { Category = compare },
> > + { ModeNum = 0 } % sanity check
> > + ; remove_prefix("__Index__") ->
> > + { Category = index },
> > + { ModeNum = 0 } % sanity check
> > + ;
> > + { Category = ordinary }
> > + ),
>
> I don't know whether "sanity check" is the right comment. If it's a
> sanity check, they should use require. Instead, it rejects them as a
> pred symbol, and doesn't demangle them.
It shouldn't use require, because the input could be any old random junk,
and calling error/1 merely because the user gave us the wrong input is
undesirable behaviour.
Perhaps it would be clearer if I just delete those comments.
> the filename doesn't match this comment
> or this module declaration.
Oops. Thanks.
--
Fergus Henderson <fjh at cs.mu.oz.au> | "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh> | of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3 | -- the last words of T. S. Garp.
More information about the developers
mailing list