[m-rev.] for post-commit review: fix the c_debug grade component

Julien Fischer jfischer at opturion.com
Wed Jul 30 20:44:42 AEST 2025


On Wed, 30 Jul 2025 at 20:16, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Fix the c_debug grade component.
>
> Until now, it kept debugging symbols in .o files, but not in executables.
>
> scripts/ml.in:
>     Ask the linker (via the C compiler) to preserve debugging symbols
>     if the grade includes the c_debug component.
>
> diff --git a/scripts/ml.in b/scripts/ml.in
> index d41073299..18d3bd860 100644
> --- a/scripts/ml.in
> +++ b/scripts/ml.in
> @@ -352,27 +352,28 @@ esac
>
>  # compile_target_code.m falls back to calling `strip' separately if using a

Not part of your change, but that comment is now out of date: it's
link_target_code.m that handles the `strip' command within the compiler.

The diff looks fine.

Julien.


More information about the reviews mailing list