[m-rev.] for post-commit review: semantic help pieces for grade options

[Julien Fischer]

On Wed, 2 Jul 2025 at 20:22, Zoltan Somogyi <zoltan.somogyi at runbox.com>
wrote:

>
>
> On Wed, 2 Jul 2025 16:54:40 +1000, Julien Fischer <jfischer at opturion.com>
> wrote:
> > The rest looks fine.
>
> Thanks for all of that. The attached diff addresses all your comments.
>

I have one somewhat belated comment on this.

> diff --git a/tests/warnings/help_text.err_exp
b/tests/warnings/help_text.err_exp
> index 56cb25734..2d33dfd0e 100644
> --- a/tests/warnings/help_text.err_exp
> +++ b/tests/warnings/help_text.err_exp

...

> @@ -385,7 +397,11 @@ Grade options
>
>      --memory-profiling                  (grade modifier: `.memprof')
>          Prepare the generated code for profiling of memory usage and
retention
> -        by mprof. This option is supported only when targeting C.
> +        by mprof. Please see the
> +        "Using mprof for profiling memory retention" section in the
Mercury
> +        User's Guide for details.

I don't think memory rentention profiling is the main thing that memprof
grades
are used for, so I would either say:

   Please see the "Using mprof for profiling memory allocation" and
   "User mprof for profiling memory retention" sections in the Mercury
   User's Guide for details.

or, if you have to list one only section, point to the allocation one.

Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20250714/232021e6/attachment.html>