[m-rev.] for review: make warning/info messages conditional on an option

[Zoltan Somogyi]

On Mon, 18 Aug 2025 17:38:53 +1000, Peter Wang <novalazy at gmail.com> wrote:
> > @@ -2507,6 +2543,13 @@ optdb(oc_warn_dodgy_mod, warn_too_private_instances,   bool(no),
> >          w("Generate a warning if an instance declaration"),
> >          w("that can be relevant outside the current module"),
> >          w("is not exported.")])).
> > +optdb(oc_warn_dodgy_mod, warn_subtype_ctor_order,      bool(yes),
> > +    help("warn-subtype-ctor-order", [
> > +        w("Do not warn about a subtype definition that lists its"),
> > +        w("data constructors in a different order than its supertype.")])).
> > +optdb(oc_warn_dodgy_mod, warn_opt_deps_spec,           bool(yes),
> > +    priv_help("warn-opt-deps-spec", [
> > +        w("XXX Peter, please document this warning.")])).
> >  
> 
> --warn-trans-opt-deps-spec
>     Do not warn about missing or unknown module names
>     in the --trans-opt-deps-spec file.

I went with

Do not warn about missing or unknown module names
in files named by --trans-opt-deps-spec options.

> > +optdb(oc_warn_dodgy_goal, warn_unknown_warning_name, bool(yes),
> > +    help("warn-unknown-warning-name", [
> > +        w("When processing disable_warning scopes, do not report"),
> > +        w("unknown warning names in the list of warnings to disable.")])).
> 
> Perhaps:
> 
>     Do not report unknown warning names listed at the start of a
>     disable_warning(s) scope.

I went with

Do not report unknown warning names in the list of warnings
to disable in disable_warning(s) scopes.

> That looks fine, otherwise.

Thank you. I followed all your other suggestions.
I will act on the ZZZs in followup commits.

Zoltan.