[m-rev.] for review: delete old code for invoking the C# compiler
Julien Fischer
jfischer at opturion.com
Sun Aug 17 20:04:12 AEST 2025
On Sun, 17 Aug 2025 at 19:20, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
> On Sun, 17 Aug 2025 15:10:55 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> > Delete old code for invoking the C# compiler.
> >
> > There are currently two separate predicates used for invoking the C# compiler.
> > One is in make.module_target and is used to create executables and libraries
> > in the C# grade.
>
> I see no code to compile C# code in make.module_target.m. I see only an
> invocation of a predicate in link_target_code.m used to achieve compilation;
> the code itself is in link_target_code.m.
You're correct; I meant link_target_code.m there.
> > Delete the code for invoking the C# compiler in compile_target_code, since it
> > has no users and is almost certainly affected by bitrot at this point.
>
> Reword this to specify that it has no users *after* this diff; it had some before the diff.
Done.
> > compiler/compile_target_code.m:
> > Delete the compile_csharp_file/8 predicate. It is unused.
>
> I would leave in its place a pointer to a place in either make.module_target.m
> or link_target_code.m that explains what we do instead.
Done.
Thanks for the review.
Julien.
More information about the reviews
mailing list