[m-rev.] for review: d_file_deps improvements

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Aug 11 18:18:17 AEST 2025



On Mon, 11 Aug 2025 17:30:07 +1000, Peter Wang <novalazy at gmail.com> wrote:
> On Sat, 09 Aug 2025 17:42:11 +0200 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> > +    CMainRuleAction1Line1 =
> > +        "$(ML) $(ALL_GRADEFLAGS) $(ALL_MLFLAGS) -- $(ALL_LDFLAGS)",
> > +    CMainRuleAction1Line2 =
> > +        "$(EXEFILE_OPT)" ++ ExeFileName ++ "$(EXT_FOR_EXE)",
> > +    CMainRuleAction1Line3 =
> > +        InitObjFileName ++ " " ++ ModuleMakeVarNameOs,
> > +    CMainRuleAction1Line4 =
> > +        All_MLObjs ++ " $(ALL_MLLIBS)",
> > +    CMainRuleAction1Lines = make_multiline_action(
> > +        [CMainRuleAction1Line1, CMainRuleAction1Line2,
> > +        CMainRuleAction1Line3, CMainRuleAction1Line4]),
> 
> Naming each line with a variable seems to make it less readable,
> but anyway.

You are right; I deleted the names. I followed all your other suggestions
as well. Thanks for the review.

Zoltan.


More information about the reviews mailing list