[m-rev.] for review: fix mantis bug #559, step 2

Zoltan Somogyi zoltan.somogyi at runbox.com
Fri May 6 15:29:19 AEST 2022


2022-05-06 15:12 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
> The rest looks fine -- thanks for looking into this so promptly.

You are welcome. I followed all your suggestions.

I would like to ask you to benchmark the effect of this change as well,
maybe with fewer optimination levels (say just 2 and 5), but with more
repetitions, say 12 or 16 instead of 6. The reason I ask is that the technique
I used for disjunctions is also applicable to conjunctions and if-then-else
chains. So if the overall effect of this change is a speedup, then it would
make sense to try to apply it to them as well, though the average length
of if-then-else-chains may be too low for the startup&teardown overhead
to be amortized by faster iterations. (Iterations that move a lot up
and then a lot down on the stack will have more cache misses than
versions of those iterations that always use the same few stack frames.)

Zoltan.


More information about the reviews mailing list