[m-rev.] for review: avoid the failure of hard_coded/parse

Julien Fischer jfischer at opturion.com
Wed May 4 14:06:27 AEST 2022


For review by anyone.

----------------------

Avoid the failure of hard_coded/parse.

The test hard_coded/parse tests two separate things:

1. for the presence of a bug, reported in Mercury 0.9, that occurred when a
    local module name shadowed that of a browser module.

2. static linking.

Specifically, the latter tests whether statically linking against the system
libraries works. As most operating systems these days do not ship with static
versions of their system libraries installed by default, this test fails more
often than not. (Indeed, it will never pass on macOS since executables are
required to use the libSystem dylib.)

Delete the static linking aspect of this test, since it is failing almost
everywhere anyway.

tests/hard_coded/Mercury.options:
     Do not link the parse test case with --static.

Julien.

diff --git a/tests/hard_coded/Mercury.options b/tests/hard_coded/Mercury.options
index d2d7b72..7a86ee0 100644
--- a/tests/hard_coded/Mercury.options
+++ b/tests/hard_coded/Mercury.options
@@ -171,8 +171,7 @@ CFLAGS-user_compare = -Wno-tautological-compare
  # tracking it down.
  MLFLAGS-mode_choice = --no-strip

-# We want to have at least one test case to test static linking; this is it.
-MLFLAGS-parse		=	--trace --static
+MLFLAGS-parse		=	--trace

  CFLAGS-no_refs_to_deleted_labels = -DMR_DEBUG_LABEL_NAMES



More information about the reviews mailing list