[m-rev.] diff: Delete unused imports.

Peter Wang novalazy at gmail.com
Wed Mar 30 16:17:07 AEDT 2022


On Wed, 30 Mar 2022 15:07:57 +1100 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 
> On Wed, 30 Mar 2022 14:53:26 +1100, Peter Wang <novalazy at gmail.com> wrote:
> > > Actually, the reason why the import of vartypes was flagged as unused
> > > with --intermod-opt was a known limitation that we discussed in october:
> > 
> > If flagging vartypes as unused is due to a limitation, then would the
> > opposite behaviour, i.e. flagging vartypes as USED in call_gen.m,
> > be correct? Anyway, we both agree the answer to that is "no".
> 
> I don't agree. I have been saying that mmc's correct behavior for the version
> of call_gen.m that includes an implementation section import of vartypes.m,
> is NOT to generate an unused import warning for that import.
> 

Then call_gen.m must be using an entity exported by vartypes.m, correct?
Can you explain to me what constitutes the "use" in call_gen.m?

> In any case, "flagging", to me, means reporting that something is wrong,
> so the idea of "flagging an import as used" does not make sense.

Ok, I meant it in the sense of "setting a flag".

Peter


More information about the reviews mailing list