[m-rev.] for review: io.stream_db.m

Julien Fischer jfischer at opturion.com
Fri Mar 11 22:30:50 AEDT 2022


On Fri, 11 Mar 2022, Zoltan Somogyi wrote:

> 2022-03-11 18:05 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> Ok, I'm still inclined to place it in the submodule however.
>
> That is what I committed.
>
>> Related to this: why is there a declaration for the type stream_id/0
>> in the publicly documented interface of io.m?  There's nothing in that
>> part of the interface that would allows users to do anything with a
>> stream_id value.
>
> Agreed. The attached diff, most of which addresses one of Peter's
> earlier reviews, also deletes this redundant type declaration.

Unfortunately, its removal breaks installation in the Java grade.

    Making Mercury/javas/jmercury/mdb__browser_info.java
    Uncaught Mercury exception:
    Software Error: map.lookup: key not found
         Key Type: string
         Key Value: "stream_id"
         Value Type: tree234.tree234(parse_tree.prog_data.type_ctor,
           hlds.hlds_data.hlds_type_defn)

(At a guess this may have something to do with the handling of
equivalence types in the Java backend?)

Julien.


More information about the reviews mailing list