[m-rev.] for review: simplify options_file error handling

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Jan 23 03:34:15 AEDT 2022


2022-01-23 01:30 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> +        Specs = [_ | _],
>> +        % Returning error1 here is correct because all specs the Specs
> 
>   ... all spec in Specs

Done.

>> +        % will have severity_error. There is (as of this writing) exactly
>> +        % one place in this module that generates an error_spec whose
>> +        % severity is NOT severity_error, but it is not reachable from
>> +        % lookup_options_variable.
>> +        Result = error1(Specs)
>> +    ).
> 
> The rest looks fine.

Thanks for that.

Since you didn't object, this deletes all references to erlang
in the compiler directory, with only a few exceptions.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.erl
Type: application/octet-stream
Size: 908 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220123/8b0a893a/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.erl
Type: application/octet-stream
Size: 27010 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20220123/8b0a893a/attachment-0003.obj>


More information about the reviews mailing list