[m-rev.] for review: avoid misleading error message

Julien Fischer jfischer at opturion.com
Wed Feb 9 12:20:37 AEDT 2022



On Wed, 9 Feb 2022, Zoltan Somogyi wrote:

> For Julien to review, test and apply to the release, if successful.

> diff --git a/configure.ac b/configure.ac
> index f4d882b40..221483262 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -355,10 +355,11 @@ AC_PATH_PROG(BOOTSTRAP_MC,mmc)
>  case $BOOTSTRAP_MC in
>      *Windows*|*system32*|*WINNT*)
>          BOOTSTRAP_MC=
> -        MERCURY_MSG("wrong mmc ignored")
> +        MERCURY_MSG("ignoring Microsoft Management Console")
>          ;;
>  esac
> 
> +DETECTED_MC="$BOOTSTRAP_MC"
>  if test "$BOOTSTRAP_MC" != ""
>  then
>      AC_MSG_CHECKING(whether the above mmc works and is sufficiently recent)
> @@ -3329,8 +3330,15 @@ fi
>
>  if test "$BOOTSTRAP_MC" = ""; then
>      GRADE="$BOOTSTRAP_GRADE"
> +    if test "$DETECTED_MC" = ""
> +    then
> +        MC_UNAVAIL_MSG="Mercury compiler not yet installed"
> +    else
> +        MC_UNAVAIL_MSG="Installed Mercury compiler is not up to date"
> +    fi
> +    MC_ERROR
>      AC_MSG_WARN(
> -[Mercury compiler not yet installed -
> +[$MC_UNAVAIL_MSG compiler not yet installed -

Delete the words "compiler not yet installed" there.

>  ****    cannot use grade '$BEST_GRADE_FOR_COMPILER'
>  ****    using grade '$GRADE' to compile the compiler
>  ****    after installation is complete you may reinstall

The rest looks fine.

Julien.


More information about the reviews mailing list