[m-rev.] for post-commit review: allocate type_info vars separately from initialization

Julien Fischer jfischer at opturion.com
Wed Apr 20 16:37:51 AEST 2022


On Wed, 20 Apr 2022, Zoltan Somogyi wrote:

> 2022-04-20 14:44 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:

>> Unrelated to this diff: why is Java a special case here?
>> (It seems unusual that is is not Java *and* C#, given that those backends
>> are quite similar in most respects.)
>
> TypeInfo_Struct.java has no constructor that takes an arity argument.
> The comment there about it says that (a) it is not needed, because the
> constructor can compute the arity for itself, and (b) it is not allowed by
> Java 1.7 :-) The fact that the two fields in that structure are a (reference to)
> a type_ctor_info structure and an array of type_infos means that the
> array records the arity whether you want to or not.
>
> I have not looked at the C# version.

I will take a look at it and amend the comment if necessary.

Julien.


More information about the reviews mailing list