[m-rev.] for review: delete obsolete procedures from string module

[Zoltan Somogyi]

2022-04-13 22:57 GMT+10:00 "Julien Fischer" <jfischer at opturion.com>:
> There are tests in that directory that emit warnings,

A grep for "Warning" in tests/invalid*/*err_exp yields 33 matching files.
I also don't know whether they are intentional.

> I haven't looked at whether those warnings are germane to what is being
> tested.

In this case, it is germane; the existing test tests the handling of mode-specific
clauses.

> However, my feeling is that specific tests for warnings ought
> to go into tests/warnings.  I would be inclined to disable the new
> warning for the test in tests/invalid

Traditionally, we have not done that in situations like this, as the 33 hits
above shows.

> and retain the specific test
> case in tests/warnings.

I will commit the diff as is. Peter can cast a tiebreaking vote post-commit, if he wishes.

Zoltan.