[m-rev.] for post-commit review: improve error messages for initialise/finalise

[Peter Wang]

On Mon, 24 May 2021 03:39:01 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by anyone.
> 
> Zoltan.

> Fix error messages for initialise/finalise decls.
> 
> compiler/make_hlds_passes.m:
>     When rejecting a predicate due to a invalid signature, say what
>     a valid signature looks like.
> 
>     Replace two cut-and-pasted predicates with one parameterised predicate.
> 
> compiler/parse_mutable.m:
>     Replace two different error messages for malformed name/arity in
>     initialise and finalise declarations respectively with one message
>     that follows the same patterns as many of our other error messages.
> 
> tests/invalid/bad_finalise_decl.err_exp:
> tests/invalid/bad_initialise_decl.err_exp:
>     Expect the updated error messages.

That looks fine.

Peter