[m-rev.] for post-commit review: clarify wording in manual
Julien Fischer
jfischer at opturion.com
Thu May 20 22:48:28 AEST 2021
On Thu, 20 May 2021, Zoltan Somogyi wrote:
> The reason I looked at this part of the manual was because
> in the course of working on something else, I looked at the
> code adding initialise and finalise preds to the HLDS, and
> I found it strange that this code does NOT insist on
> the symname/arity pair specified in an initialise or finalise
> declaration actually being a predicate; it would happily accept
> a function whose arg list, after the conversion of the function
> to predicate form, matches the compiler's expectations.
>
> The documentation does say that initialise and finalise
> declarations should specify predicates, not functions.
> Would anyone object if I changed the code to enforce this?
No, go ahead.
The diff is fine.
Julien.
More information about the reviews
mailing list