[m-rev.] for review: more info in diagnostics for subtype errors

Julien Fischer jfischer at opturion.com
Wed Jun 30 19:25:34 AEST 2021


On Wed, 30 Jun 2021, Zoltan Somogyi wrote:

>
> 2021-06-30 14:55 GMT+10:00 "Peter Wang" <novalazy at gmail.com>:
>>> +subtype_abstract.m:012: Error: the type definition for `citrus'/0,
>>> +subtype_abstract.m:012:   the super type of `lemon'/0,
>>> +subtype_abstract.m:012:   is not visible here.
>> 
>> Perhaps it would be an improvement to add the word "declared", as in:
>>
>>     Error: the type definition for `citrus'/0,
>>       the declared super type of `lemon'/0,
>>       is not visible here.
>
> In the presence of a longer chain of supertypes, are you proposing
> to add "declared" to just the first supertype, or all supertypes in the chain?
>
>> It's not necessary, though.
>
> OK, I am committing the diff as is with your two corrections above this.
> I will add "declared" in a separate commit once you tell me your preference.
>
> BTW, is anyone going to review the uint->uintN diff? My change to du_type_layout.m
> needs it.

I will take a look at it a bit later this evening.

Julien.


More information about the reviews mailing list