[m-rev.] for post-commit review: make recently move code fit in better

Peter Wang novalazy at gmail.com
Mon Jun 21 12:44:56 AEST 2021

On Sat, 19 Jun 2021 20:12:28 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by Peter, since the main substantive change
> is to float_regs.m.
> Zoltan.

> Make code moved to builtin_lib_types.m fit in.
> compiler/builtin_lib_types.m:
>     As above: change predicate/function names to fit in better.
>     Insist that the type of typeclass_infos have arity 0.
> compiler/float_regs.m:
>     Conform to the changes above.
>     Fix a test: consider the type of type_ctor_infos to be rtti types.
>     The code already considered the type of type_infos to be rtti types,
>     but did not consider that for arity-0 types, we use type_ctor_infos
>     to act as their type_infos.
> compiler/higher_order.m:
> compiler/ml_type_gen.m:
> compiler/polymorphism.m:
> compiler/polymorphism_type_class_info.m:
>     Conform to the changes above.

That looks fine.


More information about the reviews mailing list