[m-rev.] for post-commit review: stricter checking of tabling pragmas vs the grade

Julien Fischer jfischer at opturion.com
Mon Jun 14 19:53:59 AEST 2021

On Mon, 14 Jun 2021, Zoltan Somogyi wrote:

> There is a minor independent change to mercury_grade.h as well.
> For review by anyone.

> Stricter checking of tabling pragmas vs grades.


> compiler/add_pragma.m:
> compiler/add_pragma_tabling.m:
> compiler/dead_proc_elim.m:
> compiler/det_report.m:
> compiler/hlds_out_pred.m:
> compiler/item_util.m:
> compiler/layout_out.m:
> compiler/llds_out_global.m:
> compiler/ml_top_gen.m:
> compiler/modes.m:
> compiler/parse_pragma.m:
> compiler/parse_pragma_tabling.m:
> compiler/parse_tree_out_pragma.m:
> compiler/prog_out.m:
> compiler/simplify_goal_call.m:
> compiler/tabling_analysis.m:
>     Conform to the changes above.
>     In several places, fix or improve error messages.
>     (Shame that none of them have tests in tests/invalid.)

It also looks like the tests in tests/tabling are set up to run in
hlc.par.gc, which will presumably no longer "work".

The diffs look fine.


More information about the reviews mailing list