[m-rev.] for post-commit review: a start on getting type repn info from .int files

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jul 28 00:32:27 AEST 2021

2021-07-27 14:50 GMT+10:00 "Zoltan Somogyi" <zoltan.somogyi at runbox.com>:
>>> I think they should be moved to separate tests directory regardless of
>>> which of the above is chosen; supporting two different ways of handling
>>> the tests in the same directory just complicates the test
>>> infrastructure. Doing that should allow for (1), which seems to be
>>> the simpler of the three options.
>> > I agree. "Anything" to simplify our makefiles.
>> >> >> With regard to the way the compiler prints out error messages during
>>> dependency generation: I assume that its current behaviour is just
>>> for historical reasons?  (i.e. collecting and printing them all at
>>> once would be the more desirable behaviour anyway)
>>> >> > Third, for the other test cases in tests/invalid*, i.e. the ones for which
>>> > making dependencies works without any errors, should (1) we make the
>>> > dependencies, and then use the <module>.ints mmake targets, and
>>> > maybe related targets, to make the required dependencies, or
>>> > (2) just execute mmc --make-short-interface/--make-interface commands
>>> > directly in the relevant mmake rules? I would prefer (1).
>>> >> I also prefer 1.
>>> > > Also 1.
> OK, I will follow both of those paths.

This diff implements the moving of test cases to the new test directory
discussed above, which I have called invalid_nodepend, as well as
another new test directory, invalid_onlydepend, with only one test case,
for which we test error messages from mmc --generate-dependencies,
which is quite different from all the other invalid tests.

For review by anyone, mostly of the dir names.

Note that this diff does not yet change the treatment of the tests
moved to invalid_nodepend; that will happen after this diff
has been committed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.inv
Type: application/octet-stream
Size: 983 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210728/63bcebb6/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.inv
Type: application/octet-stream
Size: 54777 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210728/63bcebb6/attachment-0003.obj>

More information about the reviews mailing list