[m-rev.] for review: lift restriction on formatting 64-bit integers

Julien Fischer jfischer at opturion.com
Thu Jan 7 10:41:24 AEDT 2021

On Thu, 7 Jan 2021, zoltan.somogyi wrote:

> The prednames in simplify proc are missing 6s.


> After "NOTE: C does not provide", why is there
> only one new predicate for int64s (for base 10), while there are several for uint64s (for all possible bases)? Do the predicates for nondecimal bases already exist for int64s?
> (I cant check since i am writing this on my phone, not having access to my laptop just now.) Or are they not needed? If so. why?

They are not needed, the [oxXu] specifiers all produce an unsigned
conversion.  We handle int64s for those cases by first casting to uint64
and then forwarding to the uint64 code that handles those cases.  I'll
add a comment about that.

> Under the circumstances, i cant do all the checks i would want, but the rest of the diff looked good to me.

Thanks for that.


More information about the reviews mailing list