[m-rev.] for post-commit review: avoid more overuse of higher order code

Peter Wang novalazy at gmail.com
Thu Aug 19 11:01:29 AEST 2021


On Wed, 18 Aug 2021 20:09:50 +1000 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> Split build_with_check_for_interrupt into two.
> 
> compiler/process_util.m:
>     Replace build_with_check_for_interrupt with setup_checking_for_interrupt
>     and teardown_checking_for_interrupt, two new predicates whose code is
>     respectively the part of build_with_check_for_interrupt before and after
>     the main higher order call. This makes the code at the former call sites
>     significantly easier to read, especially the ones which had higher order
>     calls inside higher order calls inside higher order calls.
> 
>     Move a type that process_util.m does not need anymore to
>     make.program_target.m.
> 
> compiler/make.build.m:
> compiler/make.module_dep_file.m:
> compiler/make.module_target.m:
> compiler/make.program_target.m:
>     Conform to the changes above.

That looks fine.

Peter


More information about the reviews mailing list