[m-rev.] for post-commit review: always compute self-import FIM langs

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Aug 17 12:00:30 AEST 2021



On Mon, 16 Aug 2021 17:05:37 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:

> 
> On Sat, 14 Aug 2021, Zoltan Somogyi wrote:
> 
> > For review by anyone. I am mostly seeking feedback about
> > whether parse_tree_module_src should have TWO fields
> > for self-import FIM languages: those languages for which
> > the current module needs a self-import FIM in the interface
> > section, and one likewise for the implementation section.
> > My take is: yes, it should.
> 
> Agreed.

The attached diff implements this.

> The diff is fine.

Thanks for the review.

Zoltan.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.self
Type: application/octet-stream
Size: 930 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210817/ec929162/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.self
Type: application/octet-stream
Size: 26614 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210817/ec929162/attachment-0003.obj>


More information about the reviews mailing list