[m-rev.] for post-commit review: maybe_succeeded

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Aug 12 06:06:01 AEST 2021


The diff is long and boring. The main issue I seek feedback on
is whether there is a better home for the new maybe_succeeded type
than process_util.m. Many of the primitives that can succeed or fail
are defined there, but not all, and with this diff, some modules import
process_util that didn't import it before.

The new type does not fit in well anywhere else that I can see;
e.g. it is quite different from everything else in maybe_error.m.
The only two other places I can think of for it are a new module
in the libs package (libs.succeeded or libs.maybe_succeeded),
or (possibly) definition in libs.m itself.

Ideas? Opinions?

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ms
Type: application/octet-stream
Size: 1058 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210812/19c4befc/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ms
Type: application/octet-stream
Size: 204097 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210812/19c4befc/attachment-0003.obj>


More information about the reviews mailing list