[m-rev.] for review: Add foreign_proc attributes may_export_body/may_not_export_body.

Peter Wang novalazy at gmail.com
Tue Apr 20 11:12:03 AEST 2021


On Fri, 16 Apr 2021 22:00:58 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> 
> Hi Peter,
> 
> On Thu, 15 Apr 2021, Peter Wang wrote:
> 
> > may_not_export seemed too general and may_not_opt_export seemed too
> > implementation-specific, so I ended up with may_not_export_body.
> > Other suggestions?
> 
> Have you learned nothing from C?  It should clearly be "static" ;-)
> 
> Aother possibility: instead of adding a new attribute pair, extend
> the existing may_duplicate/may_not_duplicate attributes with a third
> possibility, may_duplicate_local.

I like that idea, but not so much the name may_duplicate_local,
which leaves the important part implicit. I couldn't think of a better
name, so I'm going to stick with may_export_body/may_not_export_body.
We can change it if a better suggestion comes up.

Thanks for the review.

Peter


More information about the reviews mailing list