[m-rev.] for review: use enum to identify impl defined literals

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Apr 3 10:36:02 AEDT 2021


2021-04-01 16:33 GMT+11:00 "Peter Wang" <novalazy at gmail.com>:
>> Also, would people object if I made the code that converts int, float
>> and string term functors to cons_ids actually check that they have
>> no arguments? Catching mistakes such as 8("abc") only during
>> typechecking generates not-all-that-helpful error messages
>> that complain about 8 not being a function.
> 
> I don't see why not, though I don't remember making that mistake before.

It turns out that such checks would never succeed. This diff documents this fact
at the relevant places.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.args
Type: application/octet-stream
Size: 852 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210403/69940871/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.args
Type: application/octet-stream
Size: 10642 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20210403/69940871/attachment-0001.obj>


More information about the reviews mailing list